vilyaem/Xrasher
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

engine: server: fixes for userinfo change ratelimiting

Browse source 
* Add pentalty earlier
* Increase disallowed timewindow according to penality multiplier
* Allow first change even if it falls into ignore timewindow
This commit is contained in:
Alibek Omarov 2025-02-15 06:26:13 +03:00
parent bc1b86c19c
commit 340a8b5e0c
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
engine/server/sv_client.c
View file

@ -1775,7 +1775,7 @@ static qboolean SV_ShouldUpdateUserinfo( sv_client_t *cl )
if( host.realtime < cl->userinfo_next_changetime + cl->userinfo_penalty * sv_userinfo_penalty_multiplier.value ) if( host.realtime < cl->userinfo_next_changetime + cl->userinfo_penalty * sv_userinfo_penalty_multiplier.value )
{ {
// player changes userinfo too quick! ignore! // player changes userinfo too quick! ignore!
if( host.realtime < cl->userinfo_next_changetime ) if( host.realtime < cl->userinfo_next_changetime && cl->userinfo_change_attempts > 0 )
{ {
Con_Reportf( "%s: ignore userinfo update for %s: penalty %f, attempts %i\n", Con_Reportf( "%s: ignore userinfo update for %s: penalty %f, attempts %i\n",
__func__, cl->name, cl->userinfo_penalty, cl->userinfo_change_attempts ); __func__, cl->name, cl->userinfo_penalty, cl->userinfo_change_attempts );
@ -1786,15 +1786,15 @@ static qboolean SV_ShouldUpdateUserinfo( sv_client_t *cl )
} }
// they spammed too fast, increase penalty // they spammed too fast, increase penalty
if( cl->userinfo_change_attempts > sv_userinfo_penalty_attempts.value ) if( cl->userinfo_change_attempts >= (int)sv_userinfo_penalty_attempts.value )
{ {
Con_Reportf( "%s: penalty set %f for %s\n", __func__,
cl->userinfo_penalty, cl->name );
cl->userinfo_penalty *= sv_userinfo_penalty_multiplier.value; cl->userinfo_penalty *= sv_userinfo_penalty_multiplier.value;
cl->userinfo_change_attempts = 0; cl->userinfo_change_attempts = 0;
Con_Reportf( "%s: penalty set %f for %s\n", __func__, cl->userinfo_penalty, cl->name );
} }
cl->userinfo_next_changetime = host.realtime + cl->userinfo_penalty; cl->userinfo_next_changetime = host.realtime + cl->userinfo_penalty * sv_userinfo_penalty_multiplier.value;
return allow; return allow;
} }