From 51d11f8e86993e484cbb2b7d606b90e7b7d1c5ce Mon Sep 17 00:00:00 2001 From: Alibek Omarov Date: Fri, 14 Feb 2025 00:05:24 +0300 Subject: [PATCH] engine: platform: win32: remove unused log variables and checks from Win32 console, sys_con does the job --- engine/platform/win32/con_win.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/engine/platform/win32/con_win.c b/engine/platform/win32/con_win.c index 2fdbbe81..c3af611a 100644 --- a/engine/platform/win32/con_win.c +++ b/engine/platform/win32/con_win.c @@ -49,10 +49,6 @@ typedef struct qboolean inputEnabled; qboolean consoleVisible; qboolean attached; - - // log stuff - qboolean log_active; - char log_path[MAX_SYSPATH]; } WinConData; static WinConData s_wcd; @@ -502,19 +498,13 @@ create win32 console */ void Wcon_CreateConsole( qboolean con_showalways ) { - if( Sys_CheckParm( "-log" )) - s_wcd.log_active = true; - if( host.type == HOST_NORMAL ) { Q_strncpy( s_wcd.title, XASH_ENGINE_NAME " " XASH_VERSION, sizeof( s_wcd.title )); - Q_strncpy( s_wcd.log_path, "engine.log", sizeof( s_wcd.log_path )); } else // dedicated console { Q_strncpy( s_wcd.title, XASH_DEDICATED_SERVER_NAME " " XASH_VERSION, sizeof( s_wcd.title )); - Q_strncpy( s_wcd.log_path, "dedicated.log", sizeof( s_wcd.log_path )); - s_wcd.log_active = true; // always make log } s_wcd.attached = ( AttachConsole( ATTACH_PARENT_PROCESS ) != 0 ); @@ -596,10 +586,8 @@ void Wcon_DestroyConsole( void ) // last text message into console or log Con_Reportf( "%s: Unloading xash.dll\n", __func__ ); - Sys_CloseLog( NULL ); - if( !s_wcd.attached ) - { + { if( s_wcd.hWnd ) { ShowWindow( s_wcd.hWnd, SW_HIDE );